Add missing createPermissionIntegrationRouter call #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We (the permission framework maintainers) updated the correct usage of createPermissionIntegrationRouter, but the docs remained outdated. As part of fixing the docs (backstage/backstage#17388) we're making PRs to help fix the issue in community plugins as well.
|
@K-Phoen Hi! Would it be possible to take a review of this issue? We'd like to have permissions available for use in the next few weeks. Thanks! |
kurtaking
referenced
this pull request
in kurtaking/backstage-plugin-announcements
Oct 8, 2023
Signed-off-by: Kurt King <[email protected]>
Merged
3 tasks
|
@Joonpark13, I took your changes and merged them here. Was struggling to give you credit for the code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We (the permission framework maintainers) updated the correct usage of createPermissionIntegrationRouter, but the docs remained outdated. As part of fixing the docs (backstage/backstage#17388) we're making PRs to help fix the issue in community plugins as well.