-
-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use github action to publish binary programs for all platforms. #45
Conversation
pass codefactor check.
Hi @vrichv and thanks for this fantastic job! I have a few questions/requests:
This PR addresses #35 and more. Thanks again! |
I also tested linux-mips,linux-arm64 successfully. 2.I can add zip files if you decide to keep it compatible. However, I personally feel that adding multiple platforms leads to confusion with the old naming. Usually I use the following command to download:
3.ok,delete section on pull_request. |
|
Hey @vrichv , Are you willing to incorporate the requested changes? Thanks in advance |
This pull request has been automatically marked as stale because it has not had recent activity. Thank you for your contribution! |
This pull request has been automatically marked as stale because it has not had recent activity. Thank you for your contribution! |
This pull request has been automatically closed because it has not had recent activity or follow ups. |
Hey @pouriyajamshidi unfortunately I do not have access to a Linux arm64 machine but following the logic of #35 which worked, and testing the correct generation of the executable I think it should work. However, I was wondering if you have access if you could run the executable from a linux arm64 machine. Thank you! |
Hey @ChrisClarke246, Neither do I 😄. The logic seems fine. We will test it whenever we get our hands on such machine. Thanks |
Describe your changes
Use github action to publish binary programs for all platforms.
Tested: https://github.com/vrichv/tcping/releases/tag/v1.12.1
Issue ticket number and link
#35
Closes #
Checklist before requesting a review
make check
and there are no failures.Type of change