Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Arm64 support #35

Closed
pouriyajamshidi opened this issue Jun 26, 2022 · 6 comments
Closed

Add Arm64 support #35

pouriyajamshidi opened this issue Jun 26, 2022 · 6 comments
Assignees
@ChrisClarke246
Labels
good first issue Good for newcomers

Comments

@pouriyajamshidi
Copy link
Owner

Summary

With the rise of Arm chips, we should also add the binaries for those.

We need:

  1. Linux Arm64
  2. Apple Arm64

This should be instructed inside our Makefile.

Please make sure to test this and make sure the binaries work before submitting a PR.
@pouriyajamshidi pouriyajamshidi added the good first issue Good for newcomers label Jun 26, 2022
@pouriyajamshidi pouriyajamshidi moved this to Todo in TCPING Jul 16, 2022
@vrichv vrichv mentioned this issue Sep 19, 2022
Closed
4 tasks
@pouriyajamshidi pouriyajamshidi linked a pull request Sep 19, 2022 that will close this issue
Use github action to publish binary programs for all platforms. #45
Closed
4 tasks
@ChrisClarke246
Copy link
Contributor

Hey @pouriyajamshidi is this issue still open?

@ChrisClarke246
Copy link
Contributor

Is there anything left from PR #45

@pouriyajamshidi
Copy link
Owner Author

pouriyajamshidi commented Dec 3, 2023 •
edited
Loading

Hey @ChrisClarke246,

This issue is still open. That PR never conformed to the requested changes and was automatically closed.

Feel free to give it a shot.

Although, if you are up for a challenge, this can be combined with #78 since ARM64 support (for mac OS only) is already included in the Makefile here.

Thanks in advance

@ChrisClarke246
Copy link
Contributor

Thanks for clarifying. I will give this one a shot for sure and then if I have some time I'll look at #78.

@pouriyajamshidi
Copy link
Owner Author

Thanks @ChrisClarke246
Best of luck mate

@pouriyajamshidi pouriyajamshidi moved this from Todo to In Progress in TCPING Dec 3, 2023
ChrisClarke246 added a commit to ChrisClarke246/tcping that referenced this issue Dec 3, 2023
@ChrisClarke246
added support for linux arm64 in makefile conforming to the requesred…
2256781 
… changes from pouriyajamshidi#35
pouriyajamshidi pushed a commit that referenced this issue Dec 3, 2023
@ChrisClarke246
added support for linux arm64 in makefile conforming to the requesred…
e5eda00 
… changes from #35 (#167)

Co-authored-by: CHRISTIAN MCINTOSH_CLARKE <[email protected]>
@pouriyajamshidi pouriyajamshidi mentioned this issue Dec 3, 2023
Merged
3 tasks
@pouriyajamshidi
Copy link
Owner Author

resolved in #167

@github-project-automation github-project-automation bot moved this from In Progress to Done in TCPING Dec 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ChrisClarke246 ChrisClarke246

Labels
good first issue Good for newcomers
Projects
TCPING
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use github action to publish binary programs for all platforms. vrichv/tcping
2 participants
@pouriyajamshidi @ChrisClarke246