Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dialog improvements #96

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Dialog improvements #96

wants to merge 4 commits into from

Commits on Sep 14, 2024

  1. screenshot: Fix version property 

    The property needs to be lowercase.

This causes `xdg-desktop-portal` to see the version as 2, and use the
access portal if non-interactive screenshoting is requested.
    @ids1024
    ids1024 committed Sep 14, 2024
    Configuration menu
    Copy the full SHA
    ef0cf9b View commit details
    Browse the repository at this point in the history

  2. Add a Request::run helper for running cancellable task

    @ids1024
    ids1024 committed Sep 14, 2024
    Configuration menu
    Copy the full SHA
    8ca8604 View commit details
    Browse the repository at this point in the history

  3. Add a on_cancel callback method to Request::run 

    This avoids funny destructor code, and allows the cancellation handling
code to use async.
    @ids1024
    ids1024 committed Sep 14, 2024
    Configuration menu
    Copy the full SHA
    d456488 View commit details
    Browse the repository at this point in the history

  4. Derive Debug for Event 

    It is unnecessarily complicated to implement this manually. Just derive,
and any custom implementation can be done in individual structs.
    @ids1024
    ids1024 committed Sep 14, 2024
    Configuration menu
    Copy the full SHA
    a690945 View commit details
    Browse the repository at this point in the history