Dialog improvements #96
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The property needs to be lowercase. This causes `xdg-desktop-portal` to see the version as 2, and use the access portal if non-interactive screenshoting is requested.
This avoids funny destructor code, and allows the cancellation handling code to use async.
It is unnecessarily complicated to implement this manually. Just derive, and any custom implementation can be done in individual structs.
|
I see on Gnome:
So I'm not sure if looking at existing implementations helps with finding the best way to handle this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
May as well create a PR for some changes I've been working on, but more (larger) changes will be added later.
Apparently the access portal should be used for non-interactive screenshots, but that doesn't currently happen since
versionisn't advertised properly. That will also require the change from #88, and fixing up theviewof the access dialog.Not done yet (in the initial version of this PR):
xdg-desktop-portalhandle this for us? What do other portals do?