docs: Add non-equi joins to, and revise, joins docs page #19127
Conversation
github-actions
bot
added
documentation
[skip ci]
[skip ci]
rodrigogiraoserrao
force-pushed
the
docs-join-where
branch
from
fd38a74 to
1130e56
Compare
[skip ci]
[skip ci]
Without these two flags the Rust API documentation is being built and not including the related join variants.
The macro 'code_block' was updated so that we can specify Python-only or Rust-only API links that may be relevant when the two APIs differ.
We do this once as a macro so that downloading only happens when we start serving the docs instead of downloading the data every time the server reloads, which would happen if we were downloading the data in the Python snippets inside /src/python.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #19127 +/- ##
==========================================
+ Coverage 79.78% 79.79% +0.01%
==========================================
Files 1531 1532 +1
Lines 208445 208500 +55
Branches 2913 2418 -495
==========================================
+ Hits 166301 166380 +79
+ Misses 41593 41573 -20
+ Partials 551 547 -4 ☔ View full report in Codecov by Sentry. |
|
The benchmarks fail because of files missing in the docs. Can we run the prepare script beforehand? |
I was downloading the data in a separate hook but there is a test that just runs all of the Python scripts in src/python and apparently it's not trivial to get the data download to trigger just once, when the appropriate Python script test is running, so it's just easier to move the data download to the script that actually uses it. We also add a comment to the Rust script to direct users to the Python script for the data location.
I was looking at it already. I don't love it but it works. |
Fixes #18749