docs(rust): Add Rust example for tolerance join using join_asof in user guide #18696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnabanimesh
changed the title
github-actions
bot
added
documentation
arnabanimesh
changed the title
ritchie46
reviewed
Sep 14, 2024
| @@ -218,11 +218,7 @@ If you want to make sure that only quotes within a certain time range are joined | |||
| the `tolerance` argument. In this case we want to make sure that the last preceding quote is within 1 minute of the | |||
| trade so we set `tolerance = "1m"`. | |||
|
|
|||
| === ":fontawesome-brands-python: Python" | |||
There was a problem hiding this comment.
I don't understand. Why is this removed?
There was a problem hiding this comment.
I presume you are talking about why I have removed line no. 221. Python and Rust logos are already part of the auto-generated code_block template. No need for another Python logo since it will be added by the code_block anyways.
ritchie46
approved these changes
Sep 23, 2024
|
Can you do a rebase? Then it's good to go. |
arnabanimesh
force-pushed
the
patch-1
branch
from
7eedcb5 to
3be3b86
Compare
Done |
|
Fixed in PR #19127. Closing this PR. |
|
Sorry for the overlapping work, @arnabanimesh, but I really needed to include the Rust example in the PR I made. |
|
No problem @rodrigogiraoserrao. It happens. 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.