feat(python)!: Allow all DataType objects to be instantiated
#12470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
breaking
stinodego
commented
Nov 15, 2023
Comment on lines
+293
to
+303
| DataType::Int8 => { | ||
| let class = pl.getattr(intern!(py, "Int8")).unwrap(); | ||
| class.call0().unwrap().into() | ||
| }, |
There was a problem hiding this comment.
We use call0() to instantiate the Int8 class.
stinodego
commented
Nov 15, 2023
| @@ -413,6 +467,24 @@ impl FromPyObject<'_> for Wrap<DataType> { | |||
| }, | |||
| } | |||
| }, | |||
| "Int8" => DataType::Int8, | |||
There was a problem hiding this comment.
Instances of Int8 can be converted into the corresponding Rust datatype.
stinodego
commented
Nov 15, 2023
| @@ -130,7 +130,7 @@ def test_ipc_schema(compression: IpcCompression) -> None: | |||
| df.write_ipc(f, compression=compression) | |||
| f.seek(0) | |||
|
|
|||
| expected = {"a": pl.Int64, "b": pl.Utf8, "c": pl.Boolean} | |||
| expected = {"a": pl.Int64(), "b": pl.Utf8(), "c": pl.Boolean()} | |||
There was a problem hiding this comment.
The previous equality still holds - this change is just to satisfy mypy.
stinodego
requested review from
ritchie46,
alexander-beedie and
MarcoGorelli
as code owners
stinodego
force-pushed
the
dtype-update
branch
from
3f51fa0 to
ab4de0a
Compare
stinodego
force-pushed
the
dtype-update
branch
from
ab4de0a to
1f9522a
Compare
2 tasks
stinodego
changed the title
schema/dtype methodsDataType objects to be instantiated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6163
This went a lot more smoothly than I expected. This update should cause almost no friction with users.
Changes
DataTypeobjects, rather than a mix of classes/instances:Series.dtypeDataFrame.dtypesLazyFrame.dtypesDataFrame.schemaLazyFrame.schemaSeries.struct.schemaInt8()is no longer magically converted into anInt8class.__hash__,__eq__, and__repr__methods. These are valid for 'simple' data types. 'Complex' data types likeDatetimeandListoverwrite these defaults as they did before.Almost everything still works as before. The only thing really affected is the
isoperator:Before
After
>>> s.dtype is pl.Int8 FalseUse the equality operator or
isinstanceinstead:And users may have to update some of their type hints.
After this is merged, there can be a little more cleanup and refactoring to smooth things out further behind the scenes. But this should take care of the user-facing changes I intended to make.