Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SBN encoding #1085

Merged
merged 12 commits into from
Jul 25, 2023
Merged

SBN encoding #1085

merged 12 commits into from
Jul 25, 2023

Conversation

Hurricane996
Copy link
Contributor

No description provided.

@ethteck ethteck changed the title SBN encoding but this time I don't invite the wrath of Nintendo SBN encoding Jul 15, 2023
@ethteck ethteck mentioned this pull request Jul 15, 2023
@ethteck
Copy link
Member

ethteck commented Jul 15, 2023

image from Jenkins - I assume maybe a rename didn't go through?

tools/splat_ext/pm_sbn.py Outdated Show resolved Hide resolved
@ethteck ethteck requested a review from bates64 July 16, 2023 07:57
Copy link
Member

@bates64 bates64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to self: also need to confirm that the asset stack works

tools/splat_ext/pm_sbn.py Outdated Show resolved Hide resolved
tools/splat_ext/pm_sbn.py Outdated Show resolved Hide resolved
tools/splat_ext/pm_sbn.py Outdated Show resolved Hide resolved
tools/splat_ext/pm_sbn.py Outdated Show resolved Hide resolved
tools/build/configure.py Show resolved Hide resolved
tools/splat_ext/pm_sbn.py Outdated Show resolved Hide resolved
tools/splat_ext/pm_sbn.py Outdated Show resolved Hide resolved
@bates64 bates64 self-assigned this Jul 22, 2023
@ethteck
Copy link
Member

ethteck commented Jul 23, 2023

@nanaian the author said they're willing to look at this soon and address the feedback - is there a reason you self assigned this?

@bates64
Copy link
Member

bates64 commented Jul 24, 2023

Nope, will unassign if chair/Hurricane is happy to update it!

@bates64 bates64 removed their assignment Jul 24, 2023
@ethteck ethteck merged commit 96b4ec6 into pmret:main Jul 25, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants