SBN segment #1032
Closed
SBN segment #1032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethteck
reviewed
May 1, 2023
| unk_3C: int | ||
|
|
||
| def decode(self, data: bytes) -> int: | ||
| self.signature, = struct.unpack(">4s", data[0x00:0x04]) |
There was a problem hiding this comment.
If we make this a dataclass, you can make a from_bytes that looks like
@staticmethod
def from_bytes(data: bytes) -> SBNHeader:
return SBNHeader(*struct.unpack(">4siiiiiiiiiiiiiiii"))
to avoid manually setting each specific field and calling unpack a bunch of times in a row
| unk_14: bytes | ||
|
|
||
| def decode(self, data: bytes) -> int: | ||
| self.signature, = struct.unpack(">4s", data[0x00:0x04]) |
There was a problem hiding this comment.
I think here would be another good candidate for that
marijnvdwerf
reviewed
May 1, 2023
| ] | ||
|
|
||
| def get_song_symbol_name(song_id: int) -> str: | ||
| song_names = { |
There was a problem hiding this comment.
Shouldn't this be in a separate yaml file?
There was a problem hiding this comment.
yeah, probably... and separated by version. so like ver/us/song-names.yaml
|
Closing in favor of #1085 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #866!