Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with replacing bgm assets #1073

Closed
Wrymouth opened this issue Jun 27, 2023 · 3 comments
Closed

Problem with replacing bgm assets #1073

Wrymouth opened this issue Jun 27, 2023 · 3 comments
Labels
bug Something isn't working shiftability

Comments

@Wrymouth
Copy link
Contributor

I tried to replace a bgm .bin file by creating a custom asset folder in assets, then placing that folder above us in the asset stack in splat.yaml. I took a bgm file from one of my Star Rod mods, placed it in the custom asset folder, and renamed it Mario_s_House_Prologue_3E.bin. I've made a Merlon patch with the changes, which can be downloaded here. After building and running the game, it crashes immediately as seen below. I believe this is a shifting issue.

image

@bates64 bates64 added bug Something isn't working shiftability labels Jun 27, 2023
@bates64
Copy link
Member

bates64 commented Jun 27, 2023

What's is the difference in file size between your bin and the original? The BGMs being separate bins in splat are a bit of a lie and won't work unless your bin is strictly smaller than the bin it is replacing. BGMs are actually part of an archive called SBN, which we don't support yet; see #1032 for more information

@bates64
Copy link
Member

bates64 commented Jun 27, 2023

I would recommend making sure that your bin is smaller than the bin it is replacing. If it's smaller, you may also need to pad it out with zeroes to become the same size (but IIRC this isn't required). If it's too large, reduce the number of events in the song with Mamar or replace a bigger file

@Wrymouth
Copy link
Contributor Author

Smaller size doesn't work by itself, but padding the file with 0s using truncate worked. Thanks!

@bates64 bates64 closed this as completed Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working shiftability
Projects
None yet
Development

No branches or pull requests

2 participants