fix(STLExporter): no positionAttributes + TS #326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the facet normal / vertex text interpolation bug from the TS conversion and guards against positionAttribute-less meshes
CodyJasonBennett
changed the title
|
I'll need to look into the new syntax for bone transforms to clear CI (we support r128-current), but otherwise looks good. |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
|
🎉 This PR is included in version 2.29.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
This fixes the facet normal / vertex text interpolation bug from the previous TS conversion and guards against
positionAttribute-less meshes.Why
I happened to use the library before d5df2b3, and independently fixed the Typescript implementation, where a simple text interpolation error prevented string export.
Not present in either ts/js impl. is a small change to improve robustness, where a malformed (or custom) elements might break the exporter when missing a position buffer attribute. This change was implemented here, and should be up for a while.