-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Monster Spawner functionality #6187
Open
diamond-gold
wants to merge
25
commits into
pmmp:minor-next
Choose a base branch
from
diamond-gold:spawner
base: minor-next
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
70431c0
Implement spawner functionality
diamond-gold ddde846
Use entityTypeId from event
diamond-gold a34c565
CS
diamond-gold 2e38415
CS
diamond-gold db0ecd0
BC break is no more
diamond-gold 799ec82
Merge branch 'minor-next' into spawner
diamond-gold 6e877b1
Merge branch 'minor-next' into spawner
diamond-gold 3655479
Merge branch 'minor-next' into spawner
diamond-gold de7f1b4
Merge branch 'minor-next' into spawner
diamond-gold 7e42953
Use constants for default entity type id
diamond-gold c9e2f9c
Use registry for linking spawn egg to entity id
diamond-gold a3718d0
Merge branch 'minor-next' into spawner
diamond-gold b6e7e90
CS
diamond-gold ac89819
CS
diamond-gold 12cd9df
Fix entity factory giving the wrong save id
diamond-gold a5b8491
Vanilla doesn't ensure safe spawn location
diamond-gold 9bc7ad4
Test spawn range api
diamond-gold b2e4a18
Use protocol EntityIds
diamond-gold 971fb6c
Move spawning logic to from tile to block
diamond-gold 68d4fcf
Fixes
diamond-gold a82b503
Clone properties from tile to block
diamond-gold 969e704
CS
diamond-gold 0c6d8fa
Oops
diamond-gold c83cb52
Merge branch 'minor-next' into spawner
diamond-gold b4df2dc
Simpify
diamond-gold File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not liking this. A data class to wrap all these up into one item to be passed between block & tile would be a lot cleaner.