Implement Monster Spawner functionality #6187
Conversation
ShockedPlot7560
added
Category: API
are you sure this is a good idea tho
| use pocketmine\event\Cancellable; | ||
| use pocketmine\event\CancellableTrait; | ||
|
|
||
| class SpawnerAttemptSpawnEvent extends BlockEvent implements Cancellable{ |
There was a problem hiding this comment.
Wouldn't it be possible to change more values? The size, the number? Is it useful ?
There was a problem hiding this comment.
I don't think it makes sense to allow changing those in the event, those can be changed on the spawner block
|
does the author mind if i help with this pr? |
I appreciate any help, feel free to offer suggestions or PR |
| $this->spawnPerAttempt = $tile->getSpawnPerAttempt(); | ||
| $this->maxNearbyEntities = $tile->getMaxNearbyEntities(); | ||
| $this->spawnRange = $tile->getSpawnRange(); | ||
| $this->requiredPlayerRange = $tile->getRequiredPlayerRange(); |
There was a problem hiding this comment.
Not liking this. A data class to wrap all these up into one item to be passed between block & tile would be a lot cleaner.
|
This PR has been marked as "Waiting on Author", but we haven't seen any activity in 7 days. If there is no further activity, it will be closed in 28 days. Note for maintainers: Adding an assignee to the PR will prevent it from being marked as stale. |
Introduction
This PR implements the functionality of the Monster Spawner block
Changes
API changes
Added SpawnerAttemptSpawnEvent
Follow-up
TODO: spawn condition check (light level etc.)
TODO: spawnData, spawnPotentials
Tests
Not Tested