-
-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Theme sphinx-book-theme #507
Conversation
pip install sphinx-book-theme
@@ -4,5 +4,8 @@ Sphinx | |||
sphinx-rtd-theme | |||
sphinxcontrib-spelling | |||
sphinxcontrib-websupport | |||
sphinx-copybutton | |||
sphinx-togglebutton | |||
sphinx-panels |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found that sphinx-panels
is not compatible with this theme.
executablebooks/sphinx-panels#57
We can upvote it to get more attention to the issue.
sphinx-togglebutton
is fine for what we need.
|
I'ts great to see the markdown idiom MyST here in the training. I do understand now that it needs a conversation, not a side by side use of both reStructuredText and a markdown idiom. But a decision which one to take would make it clear and easy to know for the future authors what language to use for authoring. And BTW in fact I personally think it' easy to learn both. I like your approach to start with one single training to see how the conversation of existing material works. If it's not a too big effort, would you take as an example the training 'Mastering Plone Development' as there are some additional features like an extra sidebar for code checkouts and there are exercises with solutions. For your docu how to install and apply the conversation, I think it would be good to have it here in the repo. I propose to create a '_doc' folder with your documentation about myst and maybe more in the future. What do you think? |
Thanks for the feedback! |
@spereverde awsome! |
@spereverde @ksuess I would prefer not to combine two purposes into one PR, please. It is much easier for me to review focused and smaller changes. This PR and its branch Another PR could be a POC for, and documentation of, converting reStructuredText markup to MyST markup. We could convert content from reST to MyST after fiddling with the new theme. |
PR #508 for myst added |
Replaced by future PR of branch https://github.com/plone/training/tree/ksuess-theme-playground |
See requirements: #506
DONE
TODO