-
-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Myst compat #509
Myst compat #509
Conversation
Improve English grammar and syntax. Use double-backticks for literal inlines
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested it locally, LGTM
I tested it locally and converted transmogrifier as described in myst-parser.md and it worked great. |
DO NOT MERGE! I want to discuss how to migrate all the trainings, not just this one. |
Sorry for responding so late. That's what I checked:
|
I wonder if it would be easier to document what's going on, if we separate four pull requests for:
|
Aim to complete the following PRs by Thu, Sep 2, 7pm CEST/10am Pacific, when we next meet.
|
Try:
I think the original should move the
There was a somewhat related issue that was resolved. It would be good to file a report. |
hi @stevepiercy, this is superseeded, as you mentioned. Would you update your thoughts about this in "relaunch" milestone, tahnks. |
Closing in favor of #511, |
This PR provides MyST compatibility and cleans up English grammar, syntax, and spelling for the Mastering Plone training only. I did not do any other trainings, as this is for a POC. See also #508, #507, and #506.