Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6.0: Raise plone.app.widgets version to 5.0.0 with deprecation warnings. #873

Merged
merged 1 commit into from
Jul 12, 2023

Conversation

thet
Copy link
Member

@thet thet commented Jul 11, 2023

plone.app.widgets 5.0.0 deprecated itself, introduces deprecation warnings and has all code removed, which was moved to plone.app.z3cform in 4.1.0.

We are not sure if this should go into Plone 6.0 or should only be in 6.1+.
But plone.app.z3cform 4.1+ is in Plone since 6.0.4, which effectively does not use plone.app.widgets anymore.

So, should this PR be included in Plone 6.0?

/cc @mauritsvanrees @gforcada @jensens @petschki

@thet thet changed the title Raise plone.app.widgets version to 5.0.0 with deprecation warnings. 6.0: Raise plone.app.widgets version to 5.0.0 with deprecation warnings. Jul 11, 2023
@petschki
Copy link
Member

There's plone/Products.CMFPlone#3686 which will remove p.a.widget dependency of CMFPlone. We will discuss possible dependency issues with @jensens this week here at arTSPrINT Vienna and as soon as that is merged there is no p.a.widgets dendency in core anymore. The 5.0 version is ment for backwards compatibility for addons only which should IMHO be shipped in Plone 6.1 but removed in Plone 7 (as the p.a.widgets deprecation warning is already saying)

Copy link
Member

@gforcada gforcada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I will leave the decision to @mauritsvanrees although with the plans you made it seems to be 100% safe for this to get merged 😃

Great job! 👍🏾

Copy link
Member

@mauritsvanrees mauritsvanrees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slowly getting back to community work after a vacation.

Seems fine.

@jenkins-plone-org please run jobs

@thet thet merged commit 94efa5e into 6.0 Jul 12, 2023
@thet thet deleted the pawidgets-deprecation branch July 12, 2023 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants