Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6.1: Raise plone.app.widgets version to 5.0.0 with deprecation warnings. #874

Merged
merged 1 commit into from
Jul 12, 2023

Conversation

thet
Copy link
Member

@thet thet commented Jul 11, 2023

Same as #873 but for Plone 6.1. Should be safe to be merged.

/cc @mauritsvanrees @gforcada @jensens @petschki

@thet thet changed the base branch from 6.0 to 6.1 July 11, 2023 10:46
@thet thet changed the title Pawidgets deprecation 61 6.1: Raise plone.app.widgets version to 5.0.0 with deprecation warnings. Jul 11, 2023
@gforcada
Copy link
Member

Great! I'm a bit confused though:

If the changes on 5.0.0 are deprecating the package, but still providing deprecation warnings (thus, you can still import plone.app.widgets.foo and it will be working) then a major version would not be needed, right?

Then when the deprecations are actually removed, then a major release would be needed.

Still, as the package is deprecated, and thus no new release is to be expected (?) a final breaking release might be a good idea 👍🏾

Sorry for the rant 😆 😅

@jensens jensens merged commit 011b963 into 6.1 Jul 12, 2023
@jensens jensens deleted the pawidgets-deprecation-61 branch July 12, 2023 17:48
@thet
Copy link
Member Author

thet commented Jul 12, 2023

@gforcada yeah, sorry. The release was made a bit quick, just after having a short discussion with @petschki . We realized that a minor release would have been enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants