-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes to support upcoming GeminiLiveWebSocket transport #15
Merged
kompfner
merged 1 commit into
main
from
changes-to-support-gemini-live-websocket-transport
Jan 3, 2025
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,18 +3,18 @@ import Foundation | |
/// An RTVI control message sent to the Transport. | ||
public struct RTVIMessageOutbound: Encodable { | ||
|
||
let id: String | ||
let label: String | ||
let type: String | ||
let data: Value? | ||
public let id: String | ||
public let label: String | ||
public let type: String | ||
public let data: Value? | ||
|
||
/// Messages from the client to the server. | ||
public enum MessageType { | ||
static let UPDATE_CONFIG = "update-config" | ||
static let GET_CONFIG = "get-config" | ||
static let DESCRIBE_CONFIG = "describe-config" | ||
static let ACTION = "action" | ||
static let DESCRIBE_ACTIONS = "describe-actions" | ||
public static let UPDATE_CONFIG = "update-config" | ||
public static let GET_CONFIG = "get-config" | ||
public static let DESCRIBE_CONFIG = "describe-config" | ||
public static let ACTION = "action" | ||
public static let DESCRIBE_ACTIONS = "describe-actions" | ||
public static let CLIENT_READY = "client-ready" | ||
} | ||
|
||
|
@@ -59,6 +59,17 @@ public struct RTVIMessageOutbound: Encodable { | |
) | ||
} | ||
|
||
// Decode action data, if this outbound message represents an action request. | ||
// This is useful for implementing transports that can intercept and handle action requests in their own way. | ||
public func decodeActionData() -> ActionRequest? { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Where are we using it ? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
if type == RTVIMessageOutbound.MessageType.ACTION { | ||
do { | ||
let encodedData = try JSONEncoder().encode(data) | ||
return try JSONDecoder().decode(ActionRequest.self, from: encodedData) | ||
} catch {} | ||
} | ||
return nil | ||
} | ||
} | ||
|
||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I’m not mistaken, we have already removed this option from our JavaScript SDK.
Since you are already making changes, would it be worthwhile to remove it here as well now? Or should we include its removal as part of this task, along with a couple of other small refactors needed in our iOS SDK?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah I see. Looks like in the JS SDK
baseUrl
now lives nested underparams
only and not at the "top level", is that right?I wasn't necessarily looking to make any breaking changes with this PR; maybe we could save this cleanup for the next batch of work?