Changes to support upcoming GeminiLiveWebSocket transport #15
Conversation
| @@ -6,7 +6,7 @@ open class RTVIClient { | |||
|
|
|||
| private let options: RTVIClientOptions | |||
| private var transport: Transport | |||
| private var baseUrl: String | |||
| private var baseUrl: String? // see RTVIClientParams for explanation of optionality | |||
There was a problem hiding this comment.
If I’m not mistaken, we have already removed this option from our JavaScript SDK.
Since you are already making changes, would it be worthwhile to remove it here as well now? Or should we include its removal as part of this task, along with a couple of other small refactors needed in our iOS SDK?
There was a problem hiding this comment.
Ah I see. Looks like in the JS SDK baseUrl now lives nested under params only and not at the "top level", is that right?
I wasn't necessarily looking to make any breaking changes with this PR; maybe we could save this cleanup for the next batch of work?
| @@ -59,6 +59,17 @@ public struct RTVIMessageOutbound: Encodable { | |||
| ) | |||
| } | |||
|
|
|||
| // Decode action data, if this outbound message represents an action request. | |||
| // This is useful for implementing transports that can intercept and handle action requests in their own way. | |||
| public func decodeActionData() -> ActionRequest? { | |||
Agree, it might be helpful to look at the Gemini transport to understand why the changes here are helpful. Let me know if you want to do a code walkthrough first before merging this! |
kompfner
deleted the
changes-to-support-gemini-live-websocket-transport
branch
No description provided.