Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api(cdc): fix create changefeed after scale-in pd (#12003) #12029

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #12003

What problem does this PR solve?

Issue Number: close #12004

What is changed and how it works?

When the api request doesn't contain any pd address, we previously use the old pd address to create a new pd client.
If the old pd address are all scaled-in, the newly created pd client cannot connect to the upstream.
To fix this problem, in this case we should use pd client in the default upstream of the capture which can manage pd scale-in/scale-out internally.

Check List

Tests

  • Unit test
  • Manual test (add detailed scripts or steps below)
  1. Deploy a cluster with 3 pds;
  2. Scale out 3 new pds;
  3. Transfer pd leader;
  4. Scale in 3 old pds;
  5. Create changefeed;

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

Fix create changefeed after scale in pds in some scenarios.

@ti-chi-bot ti-chi-bot added lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR. labels Jan 21, 2025
@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. cherry-pick-approved Cherry pick PR approved by release team. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. do-not-merge/cherry-pick-not-approved labels Jan 21, 2025
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 21, 2025
@lidezhu
Copy link
Collaborator

lidezhu commented Jan 21, 2025

/test pull-cdc-integration-mysql-test

Copy link
Contributor

ti-chi-bot bot commented Jan 21, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lidezhu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jan 21, 2025
@lidezhu
Copy link
Collaborator

lidezhu commented Jan 21, 2025

/test all

@lidezhu
Copy link
Collaborator

lidezhu commented Jan 21, 2025

/test pull-cdc-integration-kafka-test

@ti-chi-bot ti-chi-bot bot merged commit 54a2ec5 into pingcap:release-7.5 Jan 21, 2025
13 checks passed
@lidezhu lidezhu deleted the cherry-pick-12003-to-release-7.5 branch January 21, 2025 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants