-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
api(cdc): fix create changefeed after scale-in pd #12003
Conversation
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. @@ Coverage Diff @@
## master #12003 +/- ##
================================================
+ Coverage 55.2801% 55.3902% +0.1100%
================================================
Files 1028 1028
Lines 142724 142991 +267
================================================
+ Hits 78898 79203 +305
+ Misses 58052 58000 -52
- Partials 5774 5788 +14 |
[LGTM Timeline notifier]Timeline:
|
@yudongusa PTAL |
/assign |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: asddongmen, hongyunyan, yudongusa The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/run-cherry-picker |
In response to a cherrypick label: new pull request created to branch |
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <[email protected]>
Signed-off-by: ti-chi-bot <[email protected]>
In response to a cherrypick label: new pull request created to branch |
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <[email protected]>
In response to a cherrypick label: new pull request created to branch |
What problem does this PR solve?
Issue Number: close #12004
What is changed and how it works?
When the api request doesn't contain any pd address, we previously use the old pd address to create a new pd client.
If the old pd address are all scaled-in, the newly created pd client cannot connect to the upstream.
To fix this problem, in this case we should use pd client in the default upstream of the capture which can manage pd scale-in/scale-out internally.
Check List
Tests
Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note