*: Deprecated and always set to ON tidb_enable_global_index | tidb-test=pr/2396

[mjonss]

What problem does this PR solve?

Issue Number: ref #45133

Problem Summary:
Making Global Index GA, means we can deprecate tidb_enable_global_index variable and always have it set to ON.
Also since using it need explicit mentioning of 'Global' IndexOption, it is no longer needed.

What changed and how does it work?

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No need to test

  • I checked and no code files have been changed.

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

[codecov]

Codecov Report

Attention: Patch coverage is 76.19048% with 5 lines in your changes missing coverage. Please review.

Project coverage is 58.3029%. Comparing base (66d8cdc) to head (3f7ffb9).
Report is 42 commits behind head on master.

Additional details and impacted files

@@                Coverage Diff                @@
##             master     #56169         +/-   ##
=================================================
- Coverage   72.9612%   58.3029%   -14.6584%     
=================================================
  Files          1611       1766        +155     
  Lines        447632     648559     +200927     
=================================================
+ Hits         326598     378129      +51531     
- Misses       101001     245936     +144935     
- Partials      20033      24494       +4461     

Flag	Coverage Δ
integration	40.9759% <66.6666%> (?)
unit	73.6825% <71.4285%> (+1.6421%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	53.1514% <ø> (+0.1947%)	⬆️
parser	∅ <ø> (∅)
br	65.4257% <ø> (+19.5496%)	⬆️

[mjonss]

/retest

[tiprow]

@mjonss: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2024-09-20 03:11:19.020908329 +0000 UTC m=+1189948.761332269: ☑️ agreed by Defined2014.
• 2024-09-20 08:07:23.989368377 +0000 UTC m=+1207713.729792316: ☑️ agreed by qw4990.

[mjonss]

/retest

[tiprow]

@mjonss: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[mjonss]

/retest

[tiprow]

@mjonss: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[yudongusa]

LGTM

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Defined2014, qw4990, wjhuang2016, yudongusa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [Defined2014,qw4990,wjhuang2016]
• pkg/ddl/OWNERS [wjhuang2016]
• pkg/sessionctx/variable/OWNERS [yudongusa]
• pkg/statistics/OWNERS [qw4990]
• pkg/table/OWNERS [wjhuang2016]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment