Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecated tidb_enable_table_partition, tidb_enable_list_partition and tidb_enable_global_index #18984

Merged
merged 4 commits into from
Oct 15, 2024
Merged

Deprecated tidb_enable_table_partition, tidb_enable_list_partition and tidb_enable_global_index #18984

merged 4 commits into from
Oct 15, 2024

Conversation

mjonss
Copy link
Contributor

@mjonss mjonss commented Sep 20, 2024 •
edited by hfxsd
Loading

What is changed, added or deleted? (Required)

Deprecate tidb_enable_table_partition, tidb_enable_list_partition and tidb_enable_global_index,

These were experimental flags and are no-longer needed,
Keeping them as always ON to avoid breaking existing usage.
All three requires explicit PARTITION BY, PARTITION BY LIST or GLOBAL IndexOption to be used, which should be enough.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v8.4 (TiDB 8.4 versions)
  • v8.3 (TiDB 8.3 versions)
  • v8.2 (TiDB 8.2 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 20, 2024
@mjonss mjonss changed the title Deprecated tidb_enable_list_partition, tidb_enable_table_partition and tidb_enable_global_index Deprecated tidb_enable_table_partition, tidb_enable_list_partition and tidb_enable_global_index Sep 20, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 20, 2024

@Frank945946: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hfxsd hfxsd added the v8.4 This PR/issue applies to TiDB v8.4. label Sep 23, 2024
@hfxsd hfxsd self-assigned this Sep 23, 2024
@hfxsd hfxsd added translation/doing This PR's assignee is translating this PR. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. and removed missing-translation-status This PR does not have translation status info. labels Sep 23, 2024
@hfxsd hfxsd self-requested a review September 23, 2024 01:38
hfxsd
hfxsd reviewed Sep 23, 2024
View reviewed changes
hfxsd
hfxsd reviewed Sep 23, 2024
View reviewed changes
@hfxsd hfxsd changed the title Deprecated tidb_enable_table_partition, tidb_enable_list_partition and tidb_enable_global_index Deprecated tidb_enable_table_partition, tidb_enable_list_partition and tidb_enable_global_index Sep 23, 2024
@hfxsd hfxsd mentioned this pull request Sep 23, 2024
Merged
16 tasks
hfxsd added a commit to hfxsd/docs-cn that referenced this pull request Sep 23, 2024
@hfxsd
sync pingcap/docs#18984
529b62c
hfxsd
hfxsd reviewed Sep 23, 2024
View reviewed changes
@hfxsd hfxsd requested a review from lilin90 September 23, 2024 02:37
@hfxsd hfxsd added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR's assignee is translating this PR. labels Sep 23, 2024
lilin90
lilin90 reviewed Sep 23, 2024
View reviewed changes
lilin90
lilin90 approved these changes Sep 23, 2024
View reviewed changes
Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Sep 23, 2024
@lilin90 lilin90 mentioned this pull request Sep 23, 2024
Merged
16 tasks
lilin90

This comment was marked as duplicate.

Sign in to view

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 23, 2024

@lilin90: Your lgtm message is repeated, so it is ignored.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 24, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 24, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-09-23 08:54:28.767068159 +0000 UTC m=+1469738.507492098: ☑️ agreed by lilin90.
  • 2024-09-24 03:09:14.793684087 +0000 UTC m=+1535424.534108025: ☑️ agreed by hfxsd.

@hfxsd
Copy link
Collaborator

hfxsd commented Oct 15, 2024

/approve

@ti-chi-bot ti-chi-bot bot added the approved label Oct 15, 2024
@hfxsd hfxsd closed this Oct 15, 2024
@hfxsd hfxsd reopened this Oct 15, 2024
@hfxsd
Copy link
Collaborator

hfxsd commented Oct 15, 2024

/approve

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hfxsd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot merged commit 53f1243 into pingcap:master Oct 15, 2024
13 of 14 checks passed
@mjonss mjonss deleted the deprecate-partition-sysvars branch October 15, 2024 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lilin90 lilin90 lilin90 approved these changes

@hfxsd hfxsd hfxsd approved these changes

@Frank945946 Frank945946 Frank945946 approved these changes

Assignees

@hfxsd hfxsd

Labels
approved lgtm size/M Denotes a PR that changes 30-99 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. v8.4 This PR/issue applies to TiDB v8.4.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mjonss @hfxsd @lilin90 @Frank945946