Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve serverless dms doc #15793
improve serverless dms doc #15793
Changes from 8 commits
4145e03
22fa99b
5232b93
9026e11
15efad2
19f26ca
b47773a
30bc235
9554258
92559fe
56543bb
613b818
ee6401e
8e65771
8df7898
676782e
0bfd2ed
8ffd8d4
6667dba
c241ffe
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
preview: https://pingcap-docs-website-scaffold-git-preview-cloud-57b396-qiancai.vercel.app/tidbcloud/tidb-cloud-connect-aws-dms
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"enough access" is a bit ambiguous. Could you list the specific permissions or roles needed for this AWS account or link to AWS documentation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's the second link below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"If you are unfamiliar with AWS, contact AWS Support." 这里这么写不知道是否恰当,或者 If you are unfamiliar with AWS, see xxx documentation 之类的可以吗
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
网络需要根据用户各自的情况去配置,没有一个好的文档可以看吧。