Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve serverless dms doc #15793

Merged
merged 20 commits into from
Dec 29, 2023
Merged

improve serverless dms doc #15793

merged 20 commits into from
Dec 29, 2023

Conversation

zhangyangyu
Copy link
Member

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v7.6 (TiDB 7.6 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.4 (TiDB 7.4 versions)
  • v7.3 (TiDB 7.3 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 19, 2023
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 20, 2023
@zhangyangyu zhangyangyu added the area/tidb-cloud This PR relates to the area of TiDB Cloud. label Dec 21, 2023
@qiancai qiancai added the translation/no-need No need to translate this PR. label Dec 21, 2023
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label Dec 21, 2023
@qiancai qiancai self-requested a review December 21, 2023 12:38
tidb-cloud/integrate-tidbcloud-with-aws-dms.md Outdated Show resolved Hide resolved
tidb-cloud/integrate-tidbcloud-with-aws-dms.md Outdated Show resolved Hide resolved
tidb-cloud/integrate-tidbcloud-with-aws-dms.md Outdated Show resolved Hide resolved
tidb-cloud/integrate-tidbcloud-with-aws-dms.md Outdated Show resolved Hide resolved
tidb-cloud/integrate-tidbcloud-with-aws-dms.md Outdated Show resolved Hide resolved
tidb-cloud/integrate-tidbcloud-with-aws-dms.md Outdated Show resolved Hide resolved
tidb-cloud/integrate-tidbcloud-with-aws-dms.md Outdated Show resolved Hide resolved
tidb-cloud/integrate-tidbcloud-with-aws-dms.md Outdated Show resolved Hide resolved
tidb-cloud/migrate-from-oracle-using-aws-dms.md Outdated Show resolved Hide resolved
tidb-cloud/migrate-from-oracle-using-aws-dms.md Outdated Show resolved Hide resolved
tidb-cloud/tidb-cloud-connect-aws-dms.md Outdated Show resolved Hide resolved
Copy link

ti-chi-bot bot commented Dec 27, 2023

@shiyuhang0: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.


## Network configuration

Before creating DMS resources, you need to configure network properly to ensure DMS can communicate with TiDB Cloud clusters. If you are unfamiliar with AWS, contact AWS Support. We give several possible configurations here.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"If you are unfamiliar with AWS, contact AWS Support." 这里这么写不知道是否恰当,或者 If you are unfamiliar with AWS, see xxx documentation 之类的可以吗

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

网络需要根据用户各自的情况去配置,没有一个好的文档可以看吧。

tidb-cloud/tidb-cloud-connect-aws-dms.md Outdated Show resolved Hide resolved
@Oreoxmt Oreoxmt self-requested a review December 28, 2023 08:39
github-actions bot pushed a commit to Oreoxmt/pingcap-docsite-preview that referenced this pull request Dec 28, 2023
tidb-cloud/tidb-cloud-connect-aws-dms.md Outdated Show resolved Hide resolved
tidb-cloud/tidb-cloud-connect-aws-dms.md Outdated Show resolved Hide resolved
tidb-cloud/tidb-cloud-connect-aws-dms.md Outdated Show resolved Hide resolved
tidb-cloud/tidb-cloud-connect-aws-dms.md Outdated Show resolved Hide resolved

### An AWS account with enough access

You are expected to have an AWS account with enough access to manage DMS-related resources. If not, refer to the following AWS documents:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"enough access" is a bit ambiguous. Could you list the specific permissions or roles needed for this AWS account or link to AWS documentation?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's the second link below.

tidb-cloud/tidb-cloud-connect-aws-dms.md Outdated Show resolved Hide resolved
tidb-cloud/tidb-cloud-connect-aws-dms.md Outdated Show resolved Hide resolved
media/tidb-cloud/aws-dms-tidb-cloud/aws-dms-connect-2.png Outdated Show resolved Hide resolved
media/tidb-cloud/aws-dms-tidb-cloud/aws-dms-connect-3.png Outdated Show resolved Hide resolved
media/tidb-cloud/aws-dms-tidb-cloud/aws-dms-connect-4.png Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Dec 29, 2023
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 29, 2023
Copy link

ti-chi-bot bot commented Dec 29, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-12-29 00:31:15.582807187 +0000 UTC m=+1784966.620034101: ☑️ agreed by Oreoxmt.
  • 2023-12-29 03:29:07.101138765 +0000 UTC m=+1795638.138365693: ☑️ agreed by qiancai.

@qiancai
Copy link
Collaborator

qiancai commented Dec 29, 2023

/approve

Copy link

ti-chi-bot bot commented Dec 29, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiancai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Dec 29, 2023
@ti-chi-bot ti-chi-bot bot merged commit f84e2c2 into release-7.1 Dec 29, 2023
10 checks passed
@Oreoxmt Oreoxmt deleted the dms-serverless branch December 29, 2023 06:21
@qiancai qiancai added the needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. label Dec 29, 2023
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #15916.

ti-chi-bot bot pushed a commit that referenced this pull request Dec 29, 2023
@qiancai qiancai added the needs-cherry-pick-master Should cherry pick this PR to master branch. label Jan 2, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch master: #15922.

ti-chi-bot pushed a commit to ti-chi-bot/docs that referenced this pull request Jan 2, 2024
ti-chi-bot bot pushed a commit that referenced this pull request Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/tidb-cloud This PR relates to the area of TiDB Cloud. lgtm needs-cherry-pick-master Should cherry pick this PR to master branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. translation/no-need No need to translate this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants