-
Notifications
You must be signed in to change notification settings - Fork 1.2k
multiple AZs in two regions: fix the topology example #13384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Aolin <[email protected]>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
@nolouch PTAL |
@@ -76,7 +76,7 @@ server_configs: | |||
tikv: | |||
server.grpc-compression-type: gzip | |||
pd: | |||
replication.location-labels: ["dc","zone","rack","host"] | |||
replication.location-labels: ["az","replication zone","rack","host"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the replication zone?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's better use like "region","zone","host"
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The replication zone
label is used here:
docs-cn/three-data-centers-in-two-cities-deployment.md
Lines 100 to 117 in b4eff71
tikv_servers: | |
- host: 10.63.10.30 | |
config: | |
server.labels: { az: "1", replication zone: "1", rack: "1", host: "30" } | |
- host: 10.63.10.31 | |
config: | |
server.labels: { az: "1", replication zone: "2", rack: "2", host: "31" } | |
- host: 10.63.10.32 | |
config: | |
server.labels: { az: "2", replication zone: "3", rack: "3", host: "32" } | |
- host: 10.63.10.33 | |
config: | |
server.labels: { az: "2", replication zone: "4", rack: "4", host: "33" } | |
- host: 10.63.10.34 | |
config: | |
server.labels: { az: "3", replication zone: "5", rack: "5", host: "34" } | |
raftstore.raft-min-election-timeout-ticks: 1000 | |
raftstore.raft-max-election-timeout-ticks: 1200 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Removed the needs-cherry-pick-release-6.4 label because the v6.4 docs have been archived at https://docs-archive.pingcap.com/zh/tidb/v6.4 and will no longer receive new updates. |
Removed the needs-cherry-pick-release-6.6 label because the v6.6 docs have been archived at https://docs-archive.pingcap.com/zh/tidb/v6.6 and will no longer receive new updates. |
Removed the needs-cherry-pick-release-7.0 label because the v7.0 docs have been archived at https://docs-archive.pingcap.com/zh/tidb/v7.0 and will no longer receive new updates. |
Removed the |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What is changed, added or deleted? (Required)
The
replication.location-labels
configuration inthree-data-centers-in-two-cities-deployment.md
is inaccurate.Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions (in Chinese).
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?