Skip to content

replace "data center" and "city" with "AZ" and "region" #12872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 16, 2023
Merged

replace "data center" and "city" with "AZ" and "region" #12872

merged 4 commits into from
Mar 16, 2023

Conversation

Oreoxmt
Copy link
Collaborator

@Oreoxmt Oreoxmt commented Mar 13, 2023 •
edited
Loading

What is changed, added or deleted? (Required)

  • Replace "data center" and "city" with "AZ" and "region" in the following three docs:
    • multi-data-centers-in-one-city-deployment.md
    • three-data-centers-in-two-cities-deployment.md
    • two-data-centers-in-one-city-deployment.md
  • Update medias: media/multi-data-centers-in-one-city-deployment-sample.png and media/three-data-centers-in-two-cities-deployment-03.png

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v7.0 (TiDB 7.0 versions)
  • v6.6 (TiDB 6.6 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.4 (TiDB 6.4 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@Oreoxmt Oreoxmt added type/enhancement The issue or PR belongs to an enhancement. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. area/scheduling Indicates that the Issue or PR belongs to the area of scheduling. ONCALL Relates to documentation oncall. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.4 needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. labels Mar 13, 2023
@Oreoxmt Oreoxmt requested a review from lilin90 March 13, 2023 08:52
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 13, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lilin90

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Mar 13, 2023
@Oreoxmt Oreoxmt requested a review from shenli March 13, 2023 09:04
@Oreoxmt
update medias
fa4a03d 
Signed-off-by: Aolin <[email protected]>
lilin90
lilin90 reviewed Mar 15, 2023
View reviewed changes
Oreoxmt and others added 2 commits March 16, 2023 10:50
@Oreoxmt Oreoxmt requested a review from lilin90 March 16, 2023 02:54
lilin90
lilin90 approved these changes Mar 16, 2023
View reviewed changes
Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 16, 2023
@Oreoxmt Oreoxmt added the require-LGT1 Indicates that the PR requires an LGTM. label Mar 16, 2023
@Oreoxmt
Copy link
Collaborator Author

Oreoxmt commented Mar 16, 2023

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 7f1ac7f

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 16, 2023
@ti-chi-bot ti-chi-bot merged commit 6a4fcd9 into pingcap:master Mar 16, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request Mar 16, 2023
Merged
15 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.1: #12930.

ti-chi-bot pushed a commit to ti-chi-bot/docs that referenced this pull request Mar 16, 2023
@Oreoxmt @ti-chi-bot
This is an automated cherry-pick of pingcap#12872
d280c89 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this pull request Mar 16, 2023
Merged
15 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.4: #12931.

ti-chi-bot pushed a commit to ti-chi-bot/docs that referenced this pull request Mar 16, 2023
@Oreoxmt @ti-chi-bot
This is an automated cherry-pick of pingcap#12872
f1ee39a 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this pull request Mar 16, 2023
Merged
15 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #12932.

ti-chi-bot pushed a commit to ti-chi-bot/docs that referenced this pull request Mar 16, 2023
@Oreoxmt @ti-chi-bot
This is an automated cherry-pick of pingcap#12872
e2e1fb2 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this pull request Mar 16, 2023
Merged
15 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.6: #12933.

ti-chi-bot pushed a commit to ti-chi-bot/docs that referenced this pull request Mar 16, 2023
@Oreoxmt @ti-chi-bot
This is an automated cherry-pick of pingcap#12872
98d38c4 
Signed-off-by: ti-chi-bot <[email protected]>
@Oreoxmt Oreoxmt deleted the translate/docs-cn-11762 branch March 16, 2023 08:08
ti-chi-bot added a commit that referenced this pull request Mar 16, 2023
@ti-chi-bot
replace "data center" and "city" with "AZ" and "region" (#12872) (#12933
cc0d88d 
)
ti-chi-bot added a commit that referenced this pull request Mar 16, 2023
@ti-chi-bot
replace "data center" and "city" with "AZ" and "region" (#12872) (#12932
2835f28 
)
ti-chi-bot added a commit that referenced this pull request Mar 16, 2023
@ti-chi-bot
replace "data center" and "city" with "AZ" and "region" (#12872) (#12931
5b66547 
)
ti-chi-bot added a commit that referenced this pull request Mar 16, 2023
@ti-chi-bot
replace "data center" and "city" with "AZ" and "region" (#12872) (#12930
7c0455a 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lilin90 lilin90 lilin90 approved these changes

@shenli shenli Awaiting requested review from shenli

Assignees
No one assigned
Labels
area/scheduling Indicates that the Issue or PR belongs to the area of scheduling. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. ONCALL Relates to documentation oncall. require-LGT1 Indicates that the PR requires an LGTM. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Oreoxmt @ti-chi-bot @lilin90