Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upd: DNSCrypt url fixed. #1111

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ramazansancar
Copy link

Thank you for your contribution to the Pi-hole Community!

Please read the comments below to help us consider your Pull Request.

We are all volunteers and completing the process outlined will help us review your commits quicker.

Please make sure you

  1. Base your code and PRs against the repositories developmental branch.
  2. Sign Off all commits as we enforce the DCO for all contributions
  3. Sign all your commits as they must have verified signatures
  4. File a pull request for any change that requires changes to our documentation at our documentation repo

What does this PR aim to accomplish?:
Added Archive.org link to removed link.

How does this PR accomplish the above?:
By giving the right guidance

Link documentation PRs if any are needed to support this PR:
https://github.com/DNSCrypt/dnscrypt-proxy/wiki/Installation-linux


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  6. I have checked that another pull request for this purpose does not exist.
  7. I have considered, and confirmed that this submission will be valuable to others.
  8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  9. I give this submission freely, and claim no ownership to its content.

  • I have read the above and my PR is ready for review. Check this box to confirm

Copy link

netlify bot commented Oct 8, 2024

Deploy Preview for pihole-docs ready!

Name Link
🔨 Latest commit 57c010f
🔍 Latest deploy log https://app.netlify.com/sites/pihole-docs/deploys/67048c80f5db8e0008984cf5
😎 Deploy Preview https://deploy-preview-1111--pihole-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@yubiuser yubiuser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the right solution is not to link to an archive version of an removed wiki article (which are probably outdated already - last edited 2018/19) but to port the stored (and updated) information to the doc

@ramazansancar
Copy link
Author

The Internet archive was inaccessible. So this method didn't make sense anymore. At least for a while. @yubiuser

Comment on lines 14 to +16
#### Alternatives

* An alternative would be using [DNSCrypt](https://github.com/pi-hole/pi-hole/wiki/DNSCrypt), but this leaves you in a position where you have to trust the [DNSCrypt resolver](https://www.dnscrypt.org/dnscrypt-resolvers.html) since your IP is not anonymized - [unless you configure DNSCrypt to route over Tor](https://github.com/DNSCrypt/dnscrypt-proxy/issues/399#issuecomment-214329222).
* An alternative would be using [DNSCrypt (Archive)](https://web.archive.org/web/20210907204828/https://github.com/pi-hole/pi-hole/wiki/DNSCrypt) or [DNSCrypt-2.0 (Archive)](https://web.archive.org/web/20220617185156/https://github.com/pi-hole/pi-hole/wiki/DNSCrypt-2.0), but this leaves you in a position where you have to trust the [DNSCrypt resolver](https://www.dnscrypt.org/dnscrypt-resolvers.html) since your IP is not anonymized - [unless you configure DNSCrypt to route over Tor](https://github.com/DNSCrypt/dnscrypt-proxy/issues/399#issuecomment-214329222).
Copy link
Member

@rdwebdesign rdwebdesign Oct 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original wiki pages were removed because they were really outdated (last update was 2016 or 2018).
Pointing these links to web archive (outdated content) is a bad idea.

I see 3 solutions:

  1. replace the old links with more current references to DNSCrypt (if there are good references);
  2. completely rewrite Alternatives section (maybe using different solutions) and include up-to-date references;
  3. completely remove the Alternatives section.

Personally I think the last option would be better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants