-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tweak README text and formatting #1646
Open
rdwebdesign
wants to merge
4
commits into
development
Choose a base branch
from
tweak/README_v6
base: development
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+68
−32
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
17279be
Use a better format for the "BREAKING CHANGES" alert
rdwebdesign ca7637d
Use the same logo and header used in web repo
rdwebdesign a780403
Tweak Readme text and formatting
rdwebdesign ba5d35d
Merge branch 'development' into tweak/README_v6
rdwebdesign File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suppose
v[ChangeMeBeforeTagging]
is there as Docker is more concerned about tags in the formatYYYY.MM.X
. The tag cannot be foreseen as there is no fixedv6
release date.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree we need a better text here, but the current paragraph is not wrong (maybe just incomplete).
v6
is an entirely redesigned Pi-hole. Every v6 tag will contain breaking changes compared to v5 tags.We probably need to include both:
v6
and a tag.