Tweak README text and formatting #1646
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and set the new version number to v6 Signed-off-by: RD WebDesign <[email protected]>
Signed-off-by: RD WebDesign <[email protected]>
mainly format changes, removal of trailing spaces, addition or removal of line breaks and some text corrections Signed-off-by: RD WebDesign <[email protected]>
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Signed-off-by: RD WebDesign <[email protected]>
|
Conflicts have been resolved. |
DL6ER
reviewed
Sep 25, 2024
| > [!CAUTION] | ||
| > | ||
| > ## !!! THIS VERSION CONTAINS BREAKING CHANGES | ||
| > **v6 has been entirely redesigned from the ground up and contains many breaking changes.** |
There was a problem hiding this comment.
Suggested change
| > **v6 has been entirely redesigned from the ground up and contains many breaking changes.** | |
| > **v[ChangeMeBeforeTagging] has been entirely redesigned from the ground up and contains many breaking changes.** |
I suppose v[ChangeMeBeforeTagging] is there as Docker is more concerned about tags in the format YYYY.MM.X. The tag cannot be foreseen as there is no fixed v6 release date.
There was a problem hiding this comment.
I agree we need a better text here, but the current paragraph is not wrong (maybe just incomplete).
v6 is an entirely redesigned Pi-hole. Every v6 tag will contain breaking changes compared to v5 tags.
We probably need to include both: v6 and a tag.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Mainly format changes, removal of trailing spaces, addition or removal of line breaks and some text corrections.
Using some markdown alerts to emphasize critical information.