Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change so ADD to COPY following docker best practices #1382

Merged
merged 1 commit into from
Jul 16, 2023

Conversation

Gontier-Julien
Copy link
Contributor

Change some ADD to COPY to follow docker best practices.

Description

Change some ADD to COPY to follow docker best practices.

Motivation and Context

This change follow docker best practices when it comes to dockerfile more here from the docker docs site.
https://docs.docker.com/develop/develop-images/dockerfile_best-practices/#add-or-copy

How Has This Been Tested?

Tested and working.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvements

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@sonarcloud
Copy link

sonarcloud bot commented Jul 15, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@PromoFaux PromoFaux merged commit a3a199c into pi-hole:development-v6 Jul 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants