Skip to content

Commit

Permalink
Merge pull request #1382 from Gontier-Julien/ADD-to-COPY
Browse files Browse the repository at this point in the history
Change so ADD to COPY following docker best practices
  • Loading branch information
PromoFaux authored Jul 16, 2023
2 parents 91f0771 + 1a1e4ce commit a3a199c
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions src/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ RUN if [ "$TARGETPLATFORM" = "linux/amd64" ]; then FTLARCH=amd64; \


ADD https://ftl.pi-hole.net/macvendor.db /macvendor.db
ADD crontab.txt /crontab.txt
COPY crontab.txt /crontab.txt

RUN cd /etc/.pihole && \
install -Dm755 -d /opt/pihole && \
Expand All @@ -67,8 +67,8 @@ ENV FTL_CMD=no-daemon
RUN addgroup -S pihole && adduser -S pihole -G pihole
# RUN groupadd pihole && useradd -r --no-user-group -g pihole -s /usr/sbin/nologin pihole

ADD bash_functions.sh /usr/bin/bash_functions.sh
ADD start.sh /usr/bin/start.sh
COPY bash_functions.sh /usr/bin/bash_functions.sh
COPY start.sh /usr/bin/start.sh

RUN chmod +x /usr/bin/start.sh

Expand Down

0 comments on commit a3a199c

Please sign in to comment.