-
-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add netlink implementation #2009
Conversation
…o parse IPv6 routing table Signed-off-by: DL6ER <[email protected]>
Signed-off-by: DL6ER <[email protected]>
…or using 64 bit interface statistics if available. The reason is that the legacy statistics use 32 bit conters which overflow every 4 GB of interface traffic Signed-off-by: DL6ER <[email protected]>
Signed-off-by: DL6ER <[email protected]>
…DONNED and cannot be used any longer for BOGUS testing Signed-off-by: DL6ER <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did you modify the devcontainer
plugins?
Signed-off-by: DL6ER <[email protected]>
Because these two plugins are what I manually need to reinstall after rebuilding the container once a week when a new version is pushed to GHCR. It is a step that seems worth automating. |
Signed-off-by: DL6ER <[email protected]>
This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there: https://discourse.pi-hole.net/t/i-updates-are-available/71248/3 |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
1 similar comment
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Signed-off-by: DL6ER <[email protected]>
Conflicts have been resolved. |
Holding merge until #2014 is merged as future Also, we are waiting until pi-hole/PADD#395 is ready as well. |
What does this implement/fix?
The existing implementation for
/api/network/{gateway,interface}
relied on manually parsing various files in/proc/
and/sys/class/net
. This had several drawbacks, e.g., was it not possible to get IPv6 routes (and, hence, gateways) or lifetimes and priority of IPv6 addresses.This PR instead implements Netlink which is the proper way of querying the kernel in a standardized way about routes and interface details. It is also the same method used by the popular
ip
command (e.g.ip a
andip r
):This change allows us to provide much better/more complete interface information through the API offering the base for implementing this Discourse feature request.
Note: The
prefered
(oner
) typo is a standard typo in Linux and expected.Related issue or feature (if applicable): N/A
Pull request in docs with documentation (if applicable): N/A
By submitting this pull request, I confirm the following:
git rebase
)Checklist:
developmental
branch.