-
-
Notifications
You must be signed in to change notification settings - Fork 569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add interface information #3076
Conversation
Signed-off-by: DL6ER <[email protected]>
Signed-off-by: DL6ER <[email protected]>
Signed-off-by: DL6ER <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed-off-by: DL6ER <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The issue is fixed with the latest commits.
But the appearance is broken for midnight and high contrast dark theme. For deep-midnight the hover effect is to bright.
At the moment, I'm not able to test the branch (this week is really busy) so I didn't see the issue, but looking at the code and the new CSS rules (style/vendor/bstreeview.min.css), I think the "too bright" issue is happening because the new elements use the same color for every theme: .bstreeview .list-group-item:hover{background-color:#dee2e6} Adding a new color to When I have the time I will try to add a few CSS rules to fix this elements in the dark themes. |
What does this implement/fix?
This PR implements a Discourse feature request. The particular implementation is up for discussion and possible further improvements therewhile.
Needs pi-hole/FTL#2009 (branch
tweak/api_network_info
) to work.Related issue or feature (if applicable): https://discourse.pi-hole.net/t/list-ip-v4-and-v6-address-in-web-interface/70981/11
Pull request in docs with documentation (if applicable): N/A
By submitting this pull request, I confirm the following:
git rebase
)Checklist:
developmental
branch.