Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make compatible with PHP 8.4 #67

Merged
merged 1 commit into from
Oct 31, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Client.php
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,7 @@ public function addException(\Exception $exception)
*
* If both a default exception and a default response are set, the exception will be thrown.
*/
public function setDefaultException(\Exception $defaultException = null)
public function setDefaultException(?\Exception $defaultException = null)
{
if (null !== $defaultException && !$defaultException instanceof Exception) {
@trigger_error('Clients may only throw exceptions of type '.Exception::class.'. Setting an exception of class '.get_class($defaultException).' will not be possible anymore in the future', E_USER_DEPRECATED);
Expand All @@ -223,7 +223,7 @@ public function addResponse(ResponseInterface $response)
/**
* Sets the default response to be returned when the list of added exceptions and responses is exhausted.
*/
public function setDefaultResponse(ResponseInterface $defaultResponse = null)
public function setDefaultResponse(?ResponseInterface $defaultResponse = null)
{
$this->defaultResponse = $defaultResponse;
}
Expand Down
Loading