Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make compatible with PHP 8.4 #67

Merged
merged 1 commit into from
Oct 31, 2024
Merged

Make compatible with PHP 8.4 #67

merged 1 commit into from
Oct 31, 2024

Conversation

ruudk
Copy link
Contributor

@ruudk ruudk commented Oct 31, 2024

Http\Mock\Client::setDefaultException(): Implicitly marking parameter $defaultException as nullable is deprecated, the explicit nullable type must be used instead

Http\Mock\Client::setDefaultResponse(): Implicitly marking parameter $defaultResponse as nullable is deprecated, the explicit nullable type must be used instead

@ruudk
Make compatible with PHP 8.4
37e533b 
> Http\Mock\Client::setDefaultException(): Implicitly marking parameter $defaultException as nullable is deprecated, the explicit nullable type must be used instead

> Http\Mock\Client::setDefaultResponse(): Implicitly marking parameter $defaultResponse as nullable is deprecated, the explicit nullable type must be used instead
@ruudk
Copy link
Contributor Author

ruudk commented Oct 31, 2024

@dbu please approve workflow

@dbu dbu merged commit b3e9f57 into php-http:1.x Oct 31, 2024
15 checks passed
@dbu
Copy link
Contributor

dbu commented Oct 31, 2024

thanks!

@ruudk ruudk deleted the patch-1 branch October 31, 2024 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ruudk @dbu