-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Promote speedup to top level #102
Conversation
Noted, I will try to test this on linux at the end of this week. |
Thank you @ijabz! What version of python are you running? Do you think it's ok if 3.6 is the minimum we support? |
There seems to be a bug with exporting artist so I couldn't complete test: ubuntu@ip-172-31-39-147: Also some simple nice to to haves would be :
ubuntu@ip-172-31-39-147:~/code/discogs-xml2db$ python3 run.py --export label dump-dir csv-dir
|
Thank you, @ijabz - what version of Python are you running? ( |
It says Python 2.7.6 but I do have Python 3 installed as well and the current code with speedup subfolder works for me, exports of Label, Master and Release appear to work. |
Sorry, I meant |
Oh python3 -V using 3.4.3 so I need to update then ? |
Python 3.4 is no longer an active Python release and on top of that I would like to not have to test and support with older versions. |
Okay I git pulled and all exports are now failing., I then updated to 3.7 which didn't have any effect away because I had /usr/bin/python3 -> pythong 3.4, changed the link to point to 3.7 but then complained about missing package so tried to run pip but more problems, please see below ubuntu@ip-172-31-39-147: It is important to note here: |
Test for merge_speedup code base
@ijabz - your points are fair and I will try to account for them. That being said, the minimum to expect is a working Python 3.6 installation and that includes a functioning I will try to prepare a step by step document for running this project and make use of Meanwhile, I have created a series of tests that extract a sample of 1,000 records of each of artists, labels, master, records and validate them. The tests pass on Ubuntu latest and Python 3.6, 3.7, 3.8 so I am going to assume this is PR is ready for the prime time. |
Im happy to upgrade 'System Python' to 3.6, I dont need to have multiple Pythons running I just dont understand what is wrong with my Python setup. |
@ijabz maybe this will help? https://stackoverflow.com/questions/53407801/how-can-i-adjust-pip3-using-python3-6-not-python3-4-on-ubuntu-14-04 Alternatively, if |
FYI I set up a new Ubuntu machine and this came with Python 3.6.9 and now discogs-xml2db is working. |
This PR promotes the speedup folder to top level replacing the old code.
discogsxml2db
.parser.py
andexporter.py
now reside in that folder; there's arun.py
at the top-level which takes the role ofpython export.py...
TODO: