Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make speedup subfolder the default and only discogs-xml2db mechanism #100

Closed
ijabz opened this issue Jul 29, 2020 · 2 comments · Fixed by #102
Closed

Make speedup subfolder the default and only discogs-xml2db mechanism #100

ijabz opened this issue Jul 29, 2020 · 2 comments · Fixed by #102
Assignees
Milestone

Comments

@ijabz
Copy link
Collaborator

ijabz commented Jul 29, 2020

The speedup approach is so much faster then the original approach we should really scrap the original approach and move speedup to top level. Its work fine with postgres and mysql, the only issue is the import part for Mongodb and Couch is incomplete.

@philipmat
Copy link
Owner

Would it be acceptable to tag (or branch) the current version, make the speedup the default, and direct the Mongo and Couch users to the "legacy" version, at least until we get the Mongo up-to-date too?

@ijabz
Copy link
Collaborator Author

ijabz commented Jul 29, 2020

I think so, in fact if you read the latest version of https://github.com/philipmat/discogs-xml2db/blob/master/speedup/README.md mongodb should work, but hasnt been tried.

@philipmat philipmat self-assigned this Aug 15, 2020
@philipmat philipmat added this to the v2.0 milestone Aug 15, 2020
@philipmat philipmat linked a pull request Aug 16, 2020 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants