Promote speedup to top level

.github/workflows/python-build-check.yml

@@ -3,11 +3,11 @@
 
 name: Python build check
 
-on:
-  push:
-    branches: [ develop ]
-  pull_request:
-    branches: [ develop ]
+on: [ push, pull_request ]
+#  push:
+#    branches: [ develop ]
+#  pull_request:
+#    branches: [ develop ]
 
 jobs:
   build:
@@ -26,15 +26,16 @@ jobs:
     - name: Install dependencies
       run: |
         python -m pip install --upgrade pip
-        pip install flake8 pytest
         if [ -f requirements-dev.txt ]; then pip install -r requirements-dev.txt; fi
         if [ -f requirements.txt ]; then pip install -r requirements.txt; fi
-    - name: Lint with flake8
+    - name: Lint with pycodestyle
       run: |
         # stop the build if there are Python syntax errors or undefined names
-        flake8 . --count --select=E9,F63,F7,F82 --show-source --statistics
+        # flake8 . --count --select=E9,F63,F7,F82 --show-source --statistics
+        # pycodestyle . --count --select=E9,F63,F7,F82 --show-source --statistics
         # exit-zero treats all errors as warnings. The GitHub editor is 127 chars wide
-        flake8 . --count --exit-zero --max-complexity=10 --max-line-length=127 --statistics
+        # flake8 . --count --exit-zero --max-complexity=10 --max-line-length=127 --statistics
+        pycodestyle . --count --show-source --statistics --exclude=.git,.venv,__pycache__,v1.x
     - name: Test with pytest
       run: |
         pytest

.gitignore

@@ -3,4 +3,12 @@ Session.vim
 discogs_*_*.xml
 COUCH
 tmp
+
+# JetBrains IDE folder
 .idea/
+
+# virtual environment folder
+.venv/
+
+# Visual Studio folder
+.vs/

.travis.yml

@@ -1,21 +1,23 @@
 language: python
 python:
-  - "2.6"
-  - "2.7"
   - "3.6"
-  - "nightly" # currently points to 3.7-dev
+  - "3.7"
+  - "nightly"
 
 before_install:
-  - pip install pep8
+  - pip install -r requirements-dev.txt
 
 # command to install dependencies
 install:
   - pip install -r requirements.txt
-  - pip install -U pytest
 
 # command to run tests
-# TODO: add flake8, pytest
+# Powershell:
+# pycodestyle.exe @(gci -path .\*.py, .\parsers\*.py, .\mysql\*.py, .\postgresql\*.py | select -ExpandProperty fullname )
 script:
-  - pep8 *.py
+  - pycodestyle *.py
+  - pycodestyle discogsxml2db/*.py
+  - pycodestyle mysql/*.py
+  - pycodestyle postgresql/*.py
   - python -m py_compile *.py
   - pytest -v

.vscode/launch.json

@@ -0,0 +1,23 @@
+{
+    // Use IntelliSense to learn about possible attributes.
+    // Hover to view descriptions of existing attributes.
+    // For more information, visit: https://go.microsoft.com/fwlink/?linkid=830387
+    "version": "0.2.0",
+    "configurations": [
+        {
+            "name": "Python: Current File",
+            "type": "python",
+            "request": "launch",
+            "program": "${file}",
+            "console": "integratedTerminal",
+            "args": [
+                "${input:discogsFile}"
+            ]
+        }
+    ],
+    "inputs": [{
+        "id": "discogsFile",
+        "type": "promptString",
+        "description": "Path to a discogs files (artists, labels, etc)"
+    }]
+}

.vscode/settings.json

@@ -1,5 +1,48 @@
 // Place your settings in this file to overwrite default and user settings.
 {
-    "python.linting.pep8Enabled": true,
-    "python.linting.pylintEnabled": false
+    "python.linting.pycodestyleEnabled": true,
+    "python.linting.pylintEnabled": false,
+    "python.linting.prospectorEnabled": false,
+    "python.linting.enabled": true,
+    "python.formatting.provider": "black",
+    "python.formatting.blackArgs": [
+        "--line-length",
+        "100"
+    ],
+    "[python]": {
+        "editor.formatOnSave": false
+    },
+    "cSpell.words": [
+        "ABCDEFG",
+        "Alexi",
+        "Cari",
+        "Lekebusch",
+        "apicounts",
+        "catno",
+        "contactinfo",
+        "couchimport",
+        "csvdir",
+        "discogs",
+        "fname",
+        "fobj",
+        "fpath",
+        "headerline",
+        "importcsv",
+        "iterchildren",
+        "itertools",
+        "libpq",
+        "lxml",
+        "mongoimport",
+        "namevariation",
+        "ncols",
+        "noqa",
+        "pbar",
+        "postgresql",
+        "psql",
+        "pycache",
+        "pycodestyle",
+        "pytest",
+        "tqdm",
+        "venv"
+    ]
 }

.vscode/tasks.json

@@ -0,0 +1,32 @@
+{
+    // See https://go.microsoft.com/fwlink/?LinkId=733558
+    // for the documentation about the tasks.json format
+    "version": "2.0.0",
+    "tasks": [
+        {
+            "label": "pycodestyle all files",
+            "type": "shell",
+            "command": "pycodestyle",
+            "windows": {
+                "command": "pycodestyle . --exclude=.git,.venv,__pycache__,v1.x --count --statistics"
+            },
+            "presentation": {
+                "echo": true,
+                "reveal": "always",
+                "focus": false,
+                "panel": "shared",
+                "showReuseMessage": true,
+                "clear": false
+            },
+            "problemMatcher": {
+                "fileLocation": "absolute",
+                "pattern":{
+                    "regexp": "^([^\\\\s].*):\\\\((\\\\d+,\\\\d+)\\\\):\\\\s*(.*)$",
+                    "file": 1,
+                    "location": 2,
+                    "message": 3
+                }
+            }
+        }
+    ]
+}