-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add scigraph support to the clinical-text-analysis-extension #13
Conversation
@@ -86,6 +86,7 @@ | |||
<groupId>net.sf.json-lib</groupId> | |||
<artifactId>json-lib</artifactId> | |||
<classifier>jdk15</classifier> | |||
<version>2.3</version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally, the code should be updated to use the new org.json
library instead of json-lib
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm after looking at it, I don't think the code actually uses json-lib
at all, so we could probably take off that dependency.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mvn dependency:analyze
These include: - Add a class to persist dismissed suggestions from notes. - Listen for changes on the medical history too. - Add a refresh button. - Implement pagination
@@ -23,7 +23,7 @@ | |||
<parent> | |||
<groupId>org.phenotips</groupId> | |||
<artifactId>clinical-text-analysis-extension</artifactId> | |||
<version>1.0-SNAPSHOT</version> | |||
<version>1.3-SNAPSHOT</version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't right. This is a separate module, so it doesn't use the same versioning as the main project.
See these commits. |
Cheers to @marta- for suggesting.
Reopened as #18 |
Could @AlexLapena and @itaiGershtansky review, please?