Add scigraph support to the clinical-text-analysis-extension #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -86,6 +86,7 @@ | |||
| <groupId>net.sf.json-lib</groupId> | |||
| <artifactId>json-lib</artifactId> | |||
| <classifier>jdk15</classifier> | |||
| <version>2.3</version> | |||
There was a problem hiding this comment.
Ideally, the code should be updated to use the new org.json library instead of json-lib.
There was a problem hiding this comment.
Hmm after looking at it, I don't think the code actually uses json-lib at all, so we could probably take off that dependency.
These include:
- Add a class to persist dismissed suggestions from notes.
- Listen for changes on the medical history too.
- Add a refresh button.
- Implement pagination
| @@ -23,7 +23,7 @@ | |||
| <parent> | |||
| <groupId>org.phenotips</groupId> | |||
| <artifactId>clinical-text-analysis-extension</artifactId> | |||
| <version>1.0-SNAPSHOT</version> | |||
| <version>1.3-SNAPSHOT</version> | |||
There was a problem hiding this comment.
This isn't right. This is a separate module, so it doesn't use the same versioning as the main project.
|
See these commits. |
Cheers to @marta- for suggesting.
|
Reopened as #18 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Could @AlexLapena and @itaiGershtansky review, please?