Integrating assertion rewriting properly #580
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cording to context, interface called on the debugger GUI...)
…reasons: - I don't manage to reset the source code of the modifier method in #tearDown - I willingly raise a TestFailure in my test and I want to catch it but I don't manage to do so
adri09070
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on: https://github.com/dvmason/AssertValueDebugger but more generic because it allows to generate/rewrite not only assertions but actually any type of code.
When
StDebugger>>selectedCodeRangeForContext:is called, it makes a dispatch on the exception to know if a specific selection interval should be used or if the default selection interval should be highlighted. Subclasses ofStGenerateCode(which is an exception) suggest a template method that rewrites a part of code before returning the selection interval for this piece of code. Subclasses ofStGenerateCodehave just to define which piece of code should be rewritten AND what piece of code should replace the rewritten piece of code.It works in the debugger but my unit test fails for now because:
#tearDownTestFailurein my test and I want to catch it but I don't manage to do so. I suppose I need to raise another exception (it's not important for the logic of the test)