Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrating assertion rewriting (2nd attempt) #626

Merged
merged 7 commits into from
Dec 4, 2023

Conversation

adri09070
Copy link
Contributor

@adri09070 adri09070 commented Nov 24, 2023

Based on: https://github.com/dvmason/AssertValueDebugger but more generic because it allows to generate/rewrite not only assertions but actually any type of code.

There is a problem with the test that I wrote and I don't know whym but it works in the base debugger and it won't impact the user if they don't use it

First attempt was #580 but I have way too many conflicts because of auto-refactorings linked to Tonel

…cording to context, interface called on the debugger GUI...)
…reasons:

- I don't manage to reset the source code of the modifier method in #tearDown
- I willingly raise a TestFailure in my test and I want to catch it but I don't manage to do so
…ip it) + fixing StDebuggerTest>>#tearDown and StTestDebuggerProvider>>#methodThatGeneratesCode
@adri09070 adri09070 added enhancement New feature or request debugger labels Nov 24, 2023
@adri09070 adri09070 added the need more work This needs to be improved before being considered label Nov 30, 2023
@adri09070 adri09070 removed the need more work This needs to be improved before being considered label Nov 30, 2023
@StevenCostiou StevenCostiou merged commit 14fe9a3 into pharo-spec:Pharo12 Dec 4, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
debugger enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants