Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport addition of discardBuffer to ZnBufferedReadStream>>#readInto:startingAt:count in the case that the buffer is bypassed to Pharo 11 #17382

Merged

Conversation

Rinzwind
Copy link
Contributor

This pull request backports the changes of pull request #17055 to Pharo 11.

Note that the most recent build (730), as well as the three previous ones (727–729), of the Jenkins ‘Pharo11’ job failed at the ‘Full Image-64’ stage.

…t […] Add discardBuffer to ZnBufferedReadStream>>#readInto:startingAt:count in the case that the buffer is bypassed”).
@Rinzwind
Copy link
Contributor Author

About the failing ‘Pharo11’ builds: build 730 had a ‘Segmentation fault’ at line 854 in the ‘Full Image-64‘ stage output, while the error in build 729 at line 883 in the ‘Full Image-64’ stage output seems to be due to BaselineOfNewToolsDocumentBrowser referring to an nonexistent branch ‘integration’ in the ‘Microdown’ repository, builds 728 and 727 had a similar error. Because of these failures, the most recent available Pharo 11 image does not include the changes of pull requests #16485 and #17131.

@Ducasse
Copy link
Member

Ducasse commented Nov 17, 2024

Thanks Kris.
I do not really know why P11 is breaking I did not change (or may be it was not expected) branch in microdown.

@Ducasse
Copy link
Member

Ducasse commented Nov 17, 2024

I will ask the experts around me to see what we can do.
@tesonep?

@Rinzwind
Copy link
Contributor Author

Well, I guess you just don’t remember deleting it as ‘Branch deletions’ in the repository’s ‘Activity’ shows that was already several months ago, on March 13th, along with a bunch of other branches. The ‘Compare changes’ option (screenshot below) points to commit c6ed4ba, same as on the screenshot in issue #17391.

@jecisc
Copy link
Member

jecisc commented Nov 18, 2024

In addition to microdown we also need to update the file server infos to use the new one if we want to publish new P11 images

@Rinzwind Rinzwind closed this Nov 23, 2024
@Rinzwind Rinzwind reopened this Nov 23, 2024
@Rinzwind Rinzwind closed this Nov 26, 2024
@Rinzwind Rinzwind reopened this Nov 26, 2024
@jecisc jecisc merged commit 9b6e121 into pharo-project:Pharo11 Nov 27, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants