-
-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply addition of discardBuffer to ZnBufferedReadStream>>#readInto:startingAt:count in the case that the buffer is bypassed #17055
Conversation
…t […] Add discardBuffer to ZnBufferedReadStream>>#readInto:startingAt:count in the case that the buffer is bypassed”).
Thanks for the contribution. |
Thanks a lot Kris this is cool to have you around and contributing. |
…(“Patch production build. There is a bug in the collaboration between ZipArchive and Zinc buffered streams that […]”) as the patch should no longer be necessary since the merge of pull request pharo-project#17055 (“Apply addition of discardBuffer to ZnBufferedReadStream>>#readInto:startingAt:count in […]”).
@demarey Pharo Launcher also fails to extract some of the ZIP files from our Jenkins server. I backported this fix to Pharo 12 in pull request #17112. It would be nice to have Pharo Launcher updated to Pharo 12 so it has the fix. I could backport the fix to Pharo 11 as well, but another reason to update to Pharo 12 would be Pharo Launcher issue #695. |
The launcher should take the latest image automatically normally |
@jecisc I’m not sure I understand what you mean, I meant to have Pharo Launcher itself updated. We use a ‘private’ template category for our Jenkins server. Creating an image from some of its templates signals an error at the step ‘Extracting archive to target directory’. Pharo Launcher v3.2 is based on Pharo 11 build 726 so it doesn’t yet have the fix for issue #14235. |
This pull request applies the changes from Zinc commit ca180a2. This is related to issue #14235.