Apply addition of discardBuffer to ZnBufferedReadStream>>#readInto:startingAt:count in the case that the buffer is bypassed #17055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t […] Add discardBuffer to ZnBufferedReadStream>>#readInto:startingAt:count in the case that the buffer is bypassed”).
demarey
approved these changes
Sep 9, 2024
|
Thanks for the contribution. |
|
Thanks a lot Kris this is cool to have you around and contributing. |
Rinzwind
added a commit
to Rinzwind/pharo
that referenced
this pull request
Sep 13, 2024
…(“Patch production build. There is a bug in the collaboration between ZipArchive and Zinc buffered streams that […]”) as the patch should no longer be necessary since the merge of pull request pharo-project#17055 (“Apply addition of discardBuffer to ZnBufferedReadStream>>#readInto:startingAt:count in […]”).
|
@demarey Pharo Launcher also fails to extract some of the ZIP files from our Jenkins server. I backported this fix to Pharo 12 in pull request #17112. It would be nice to have Pharo Launcher updated to Pharo 12 so it has the fix. I could backport the fix to Pharo 11 as well, but another reason to update to Pharo 12 would be Pharo Launcher issue #695. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request applies the changes from Zinc commit ca180a2. This is related to issue #14235.