Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closes #43 codeowners and #47 contributors #48

Merged
merged 6 commits into from
Aug 29, 2023
Merged

Closes #43 codeowners and #47 contributors #48

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d8d07d2
#43: update CODEOWNERS
Aug 8, 2023
6dd00ad
#47: add contributors
Aug 8, 2023
382c177
#47: update DESCRIPTION
Aug 9, 2023
24ecc4c
#47: update .Rd
Aug 9, 2023
226e1c2
Merge branch 'devel' into 43_codeowners@devel
Aug 28, 2023
a95f8d2
#43: update codeowners
Aug 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 22 additions & 3 deletions .github/CODEOWNERS
View file
Open in desktop
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
@@ -1,5 +1,24 @@
# This a CODEOWNERS file, where you can establish code owners.
# Code owners are automatically requested for review when someone opens a pull request
# that modifies code that they own. In this instance, cicdguy will be notified of any
# changes made the files inside the .github/workflows directory.
.github/workflows/* @cicdguy
# that modifies code that they own.

# admiral.test
data-raw/ds.R @Gopi2345
data-raw/lb.R @yangc71
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need to give some of these people access to the repo? otherwise the codeowners file will have errors.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it seems so, could you please grant them access if they are okay to be listed as code owners? thanks!

data-raw/mh.R @yangc71
data-raw/pc.R @toni-1991 @RealSlimMahdi
data-raw/pp.R @toni-1991
data-raw/query_databases.R @bundfussr

# admiralonco
data-raw/rs_onco.R @bundfussr
data-raw/tr_onco.R @bundfussr
data-raw/tu_onco.R @bundfussr

# admiralophtha
data-raw/ae_ophtha.R @manciniedoardo
data-raw/ex_ophtha.R @manciniedoardo
data-raw/oe_ophtha.R @manciniedoardo
data-raw/qs_ophtha.R @manciniedoardo
data-raw/sc_ophtha.R @manciniedoardo

7 changes: 0 additions & 7 deletions .github/CODEOWNERS.txt
View file
Open in desktop

This file was deleted.

7 changes: 6 additions & 1 deletion DESCRIPTION
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,12 @@ Type: Package
Title: Test Data for the Pharmaverse Family of Packages
Version: 0.0.2
Authors@R: c(
person("Edoardo", "Mancini", email = "[email protected]", role = c("aut", "cre"))
person("Edoardo", "Mancini", email = "[email protected]", role = c("aut", "cre")),
person("Kangjie", "Zhang", role = "aut"),
person("Stefan", "Bundfuss", role = "aut"),
kaz462 marked this conversation as resolved.
Show resolved Hide resolved
person("Zelos", "Zhu", role = "aut"),
person("Gayatri", "G", role = "aut"),
person("Pooja", "Kumari", role = "aut")
)
Description: A set of Study Data Tabulation Model (SDTM) datasets from the Clinical
Data Interchange Standards Consortium (CDISC) pilot project used for testing
Expand Down
9 changes: 9 additions & 0 deletions man/pharmaversesdtm-package.Rd
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading