Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #43 codeowners and #47 contributors #48

Merged
merged 6 commits into from
Aug 29, 2023

Conversation

kaz462
Copy link
Contributor

@kaz462 kaz462 commented Aug 8, 2023

Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral codebase remains robust and consistent.

Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the devel branch until you have checked off each task.

  • Place Closes #<insert_issue_number> into the beginning of your Pull Request Title (Use Edit button in top-right if you need to update)
  • Code is formatted according to the tidyverse style guide. Run styler::style_file() to style R and Rmd files
  • Updated relevant unit tests or have written new unit tests, which should consider realistic data scenarios and edge cases, e.g. empty datasets, errors, boundary cases etc. - See Unit Test Guide
  • If you removed/replaced any function and/or function parameters, did you fully follow the deprecation guidance?
  • Update to all relevant roxygen headers and examples, including keywords and families. Refer to the categorization of functions to tag appropriate keyword/family.
  • Run devtools::document() so all .Rd files in the man folder and the NAMESPACE file in the project root are updated appropriately
  • Address any updates needed for vignettes and/or templates
  • Update NEWS.md if the changes pertain to a user-facing function (i.e. it has an @export tag) or documentation aimed at users (rather than developers)
  • Build admiral site pkgdown::build_site() and check that all affected examples are displayed correctly and that all new functions occur on the "Reference" page.
  • Address or fix all lintr warnings and errors - lintr::lint_package()
  • Run R CMD check locally and address all errors and warnings - devtools::check()
  • Link the issue in the Development Section on the right hand side.
  • Address all merge conflicts and resolve appropriately
  • Pat yourself on the back for a job well done! Much love to your accomplishment!

This was linked to issues Aug 8, 2023
DESCRIPTION Show resolved Hide resolved

# admiral.test
data-raw/ds.R @Gopi2345
data-raw/lb.R @yangc71
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need to give some of these people access to the repo? otherwise the codeowners file will have errors.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it seems so, could you please grant them access if they are okay to be listed as code owners? thanks!

@kaz462
Copy link
Contributor Author

kaz462 commented Aug 9, 2023

Hi @Gopi2345 @yangc71 @toni-1991 @RealSlimMahdi,
I found you through the history of the following data programs, can we list you as code owners for them?
Code owners are automatically requested for review when someone opens a pull request that modifies code that they own.
Thanks!

data-raw/ds.R @Gopi2345 (from https://github.com/pharmaverse/admiral.test/blob/main/dev/update_ds.R)
data-raw/lb.R @yangc71 (from https://github.com/pharmaverse/admiral.test/blob/main/dev/update_lb.R)
data-raw/mh.R @yangc71 (from https://github.com/pharmaverse/admiral.test/blob/main/dev/update_mh.R)
data-raw/pc.R @toni-1991 @RealSlimMahdi (from https://github.com/pharmaverse/admiral.test/blob/main/dev/pc.R)
data-raw/pp.R @toni-1991 (from https://github.com/pharmaverse/admiral.test/blob/main/dev/pp.R)

@toni-1991
Copy link
Collaborator

Hi @Gopi2345 @yangc71 @toni-1991 @RealSlimMahdi, I found you through the history of the following data programs, can we list you as code owners for them? Code owners are automatically requested for review when someone opens a pull request that modifies code that they own. Thanks!

data-raw/ds.R @Gopi2345 (from https://github.com/pharmaverse/admiral.test/blob/main/dev/update_ds.R) data-raw/lb.R @yangc71 (from https://github.com/pharmaverse/admiral.test/blob/main/dev/update_lb.R) data-raw/mh.R @yangc71 (from https://github.com/pharmaverse/admiral.test/blob/main/dev/update_mh.R) data-raw/pc.R @toni-1991 @RealSlimMahdi (from https://github.com/pharmaverse/admiral.test/blob/main/dev/pc.R) data-raw/pp.R @toni-1991 (from https://github.com/pharmaverse/admiral.test/blob/main/dev/pp.R)

I'm fine to be includedin PC and PP

@kaz462
Copy link
Contributor Author

kaz462 commented Aug 28, 2023

@toni-1991 Thanks a lot!
@manciniedoardo could you please give @toni-1991 access to this repo?

@github-actions
Copy link

Code Coverage

Package Line Rate Health
pharmaversesdtm 0%
Summary 0% (0 / 41)

@manciniedoardo manciniedoardo merged commit d40e698 into devel Aug 29, 2023
21 checks passed
@manciniedoardo manciniedoardo deleted the 43_codeowners@devel branch August 29, 2023 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

list of contributors Full list of CODEOWNERS
3 participants