Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #2612 improve missing value handling in compute egfr #2613

Merged
merged 4 commits into from
Dec 23, 2024

Conversation

jeffreyad
Copy link
Collaborator

@jeffreyad jeffreyad commented Dec 18, 2024

Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral codebase remains robust and consistent.

Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the main branch until you have checked off each task.

  • Place Closes #<insert_issue_number> into the beginning of your Pull Request Title (Use Edit button in top-right if you need to update)
  • Code is formatted according to the tidyverse style guide. Run styler::style_file() to style R and Rmd files
  • Updated relevant unit tests or have written new unit tests, which should consider realistic data scenarios and edge cases, e.g. empty datasets, errors, boundary cases etc. - See Unit Test Guide
  • If you removed/replaced any function and/or function parameters, did you fully follow the deprecation guidance?
  • Review the Cheat Sheet. Make any required updates to it by editing the file inst/cheatsheet/admiral_cheatsheet.pptx and re-upload a PDF and a PNG version of it to the same folder. (The PNG version can be created by taking a screenshot of the PDF version.)
  • Update to all relevant roxygen headers and examples, including keywords and families. Refer to the categorization of functions to tag appropriate keyword/family.
  • Run devtools::document() so all .Rd files in the man folder and the NAMESPACE file in the project root are updated appropriately
  • Address any updates needed for vignettes and/or templates
  • Update NEWS.md under the header # admiral (development version) if the changes pertain to a user-facing function (i.e. it has an @export tag) or documentation aimed at users (rather than developers). A Developer Notes section is available in NEWS.md for tracking developer-facing issues.
  • Build admiral site pkgdown::build_site() and check that all affected examples are displayed correctly and that all new functions occur on the "Reference" page.
  • Address or fix all lintr warnings and errors - lintr::lint_package()
  • Run R CMD check locally and address all errors and warnings - devtools::check()
  • Link the issue in the Development Section on the right hand side.
  • Address all merge conflicts and resolve appropriately
  • Pat yourself on the back for a job well done! Much love to your accomplishment!

@jeffreyad jeffreyad requested review from bms63 and bundfussr December 18, 2024 21:23
@jeffreyad jeffreyad linked an issue Dec 18, 2024 that may be closed by this pull request
Copy link

github-actions bot commented Dec 18, 2024

Code Coverage

Package Line Rate Health
admiral 98%
Summary 98% (5189 / 5302)

R/compute_kidney.R Outdated Show resolved Hide resolved
tests/testthat/test-compute_kidney.R Outdated Show resolved Hide resolved
@@ -73,7 +73,9 @@ test_that("compute_egfr Test 7: CKD-EPI calculated on input data", {
"P01", "P01-1001", 55, "M", "WHITE", 90.7, 96.3, "umol/L",
"P01", "P01-1002", 52, "F", "BLACK OR AFRICAN AMERICAN", 68, 70, "umol/L",
"P01", "P01-1003", 67, "M", "BLACK OR AFRICAN AMERICAN", 85, 77, "umol/L",
"P01", "P01-1004", 76, "F", "ASIAN", 60, 65, "umol/L"
"P01", "P01-1004", 76, "F", "ASIAN", 60, 65, "umol/L",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jeffreyad just checking - this extra line in the input tests for the new lines in the function? Just want to make sure this scenario is covered adequately

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jeffreyad just checking - this extra line in the input tests for the new lines in the function? Just want to make sure this scenario is covered adequately
Yes, added a line to test for missing sex

@bms63 bms63 merged commit 76b83e6 into main Dec 23, 2024
19 checks passed
@bms63 bms63 deleted the 2612_Improve_missing_value_handling_in_compute_egfr branch December 23, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve missing value handling in compute_egfr()
3 participants