Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve missing value handling in compute_egfr() #2612

Closed
jeffreyad opened this issue Dec 17, 2024 · 1 comment · Fixed by #2613
Closed

Improve missing value handling in compute_egfr() #2612

jeffreyad opened this issue Dec 17, 2024 · 1 comment · Fixed by #2613
Assignees
Labels
enhancement New feature or request programming

Comments

@jeffreyad
Copy link
Collaborator

Feature Idea

Currently if there is a missing values for SEX in compute_egfr() the error message below results. Perhaps a warning and missing value should be returned instead.

Error in `mutate()`:
ℹ In argument: `CRCL = compute_egfr(...)`.
Caused by error in `compute_egfr()`:
! Argument `sex` must be <character> with values "M" and "F".
Run `rlang::last_trace()` to see where the error occurred.

Relevant Input

No response

Relevant Output

No response

Reproducible Example/Pseudo Code

No response

@bundfussr
Copy link
Collaborator

Makes sense to me. I wonder if we need a warning. If one the other arguments like weight is NA, NA is returned without any warning. I think this is the usual behavior in R.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request programming
Development

Successfully merging a pull request may close this issue.

2 participants