Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closes #2532 Update Forumula for Body Surface Area #2541

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Closes #2532 Update Forumula for Body Surface Area #2541

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
47aa06e
Made small change in BuBois-DuBois formula for surface area (derive_a…
jimrothstein Oct 24, 2024
3b3c2dc
ran document()
jimrothstein Oct 24, 2024
b6e2c18
use new DuBois-DuBois equation in test_that
jimrothstein Oct 24, 2024
4595cf6
run styler::styler_pkg()
jimrothstein Oct 24, 2024
1f86d84
Add to NEWS.md
jimrothstein Oct 25, 2024
fadf8c6
Put news under "Updates of Existing Functions"
jimrothstein Oct 25, 2024
ff89321
With revised DuBois-DuBois formula using meters, change units from "c…
jimrothstein Oct 29, 2024
501489d
undo (restore) incorrect changes to
jimrothstein Oct 29, 2024
ea209cc
Correct comments (HEIGHT units are in cm); NEWS.md
jimrothstein Oct 29, 2024
7561b0d
Correct NEWS.md conflict
jimrothstein Oct 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,13 @@
`AVALCATx` & `AVALCAxN`. (#2480)
- New function `derive_vars_crit_flag()` for deriving criterion flag variables
(`CRITy`, `CRITyFL`, `CRITyFLN`). (#2468)

- Replace use of `data("sdtm")` with `sdtm <- pharmaverse::sdtm` in templates and vignettes. (#2498)

## Updates of Existing Functions

- `compute_bsa(height, weight, method` - now uses improved version of DuBois-DuBois forumula for bsa (#2532)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The wording could confuse users because they may assume that the results are different now.

Either we should state that the results are still the same or we shouldn't add a NEWS entry because the change is not user-facing.

@bms63 , what do you think?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think if no change for the user then lets suppress it from user-facing notes.

@jimrothstein lets move it to developer notes just so we remember when we updated - for posterity!



## Breaking Changes

- The following function arguments are entering the next phase of the deprecation process: (#2487)
Expand Down
4 changes: 2 additions & 2 deletions R/derive_advs_params.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -462,7 +462,7 @@ derive_param_bsa <- function(dataset,
#'
#' Mosteller: sqrt(height * weight / 3600)
#'
#' DuBois-DuBois: 0.20247 * (height/100) ^ 0.725 * weight ^ 0.425
#' DuBois-DuBois: 0.007184 * height ^ 0.725 * weight ^ 0.425
#'
#' Haycock: 0.024265 * height ^ 0.3964 * weight ^ 0.5378
#'
Expand Down Expand Up @@ -521,7 +521,7 @@ compute_bsa <- function(height = height,
} else if (method == "DuBois-DuBois") {
# The DuBois & DuBois formula expects the value of height in meters
# We need to convert from cm
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment should be removed now.

bsa <- 0.20247 * (height / 100)^0.725 * weight^0.425
bsa <- 0.007184 * height^0.725 * weight^0.425
} else if (method == "Haycock") {
bsa <- 0.024265 * height^0.3964 * weight^0.5378
} else if (method == "Gehan-George") {
Expand Down
2 changes: 1 addition & 1 deletion man/compute_bsa.Rd
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions tests/testthat/test-derive_advs_params.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ test_that("compute_bsa Test 6: Mosteller method - height & weight vectors - miss
})

## compute_bsa: DuBois-DuBois method ----
# FORMULA : 0.20247 x (HGT/100)^0.725 x WGT^0.425
# FORMULA : 0.007184 x (HGT)^0.725 x WGT^0.425

## Test 7: DuBois-DuBois method - single height & weight values ----
test_that("compute_bsa Test 7: DuBois-DuBois method - single height & weight values", {
Expand Down Expand Up @@ -604,7 +604,7 @@ test_that("derive_param_bsa Test 44: BSA parameter (Mosteller Method) is correct
})

dubois <- function(hgt, wgt) {
0.20247 * (hgt / 100)^0.725 * wgt^0.425
0.007184 * hgt^0.725 * wgt^0.425
}

## Test 45: BSA parameter (DuBois-DuBois method) is correctly added ----
Expand Down
Loading